Skip to content

Commit

Permalink
Stop (ever) building from source for 1.21+
Browse files Browse the repository at this point in the history
> After reviewing the details (and how "ouroboros" it would be to solve this "properly", especially in the face of the long-term implications of https://golang.org/issues/54265), my updated proposal is that we effectively revert 11eef5d for 1.21+ -- as of Go 1.21, the _only_ architecture we actually build from source across _all_ our supported variants/distributions is arm32v5 (Debian's `armel`) because Go's published `arm` binaries are explicitly `v6` (see also 40db26d).
>
> The only suggestion of actual arm32v5 users I've managed to find is someone on one of the older Raspberry Pi devices (which are technically armv6) wanting to use a Debian-based image -- as of 1.21, the Alpine images are using the exact same upstream-provided pre-compiled binaries, so suggesting that those users switch to Alpine's arm32v6 images instead is extremely reasonable.
  • Loading branch information
tianon committed Dec 19, 2023
1 parent 46d44c1 commit 8188fe4
Show file tree
Hide file tree
Showing 14 changed files with 65 additions and 484 deletions.
1 change: 1 addition & 0 deletions .github/workflows/munge.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jq '
.matrix.include[]
| select(.name | test(" (.+)") | not) # ignore any existing munged builds
| select(.os | startswith("windows-") | not) # ignore Windows (always downloads)
| select(any(.meta.entries[].tags[]; contains("golang:1.20"))) # https://github.com/docker-library/golang/pull/500#issuecomment-1863578601
| .name += " (force build)"
| .runs.build = ([
"# update versions.json to force us to build Go instead of downloading it",
Expand Down
2 changes: 1 addition & 1 deletion 1.20/alpine3.18/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion 1.20/alpine3.19/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 0 additions & 54 deletions 1.21/alpine3.18/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 0 additions & 54 deletions 1.21/alpine3.19/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

53 changes: 0 additions & 53 deletions 1.21/bookworm/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

59 changes: 0 additions & 59 deletions 1.21/bullseye/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 0 additions & 54 deletions 1.22-rc/alpine3.18/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 8188fe4

Please sign in to comment.