We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Was looking at people updating to latest v6 of build-push-action and saw this summary generation: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951
Seems like the username/handle is used as secret: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/workflow#L17
username: ${{ secrets.DOCKERHUB_USERNAME }}
And therefore any part of the summary containing the secret value is redacted which breaks .dockerbuild link:
.dockerbuild
https://github.com/***/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534
And global rendering of the summary:
Corrected link is: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534
Which returns the right .dockerbuild filename as we upload the object with Content-Disposition header that is unredacted:
Content-Disposition
actions-toolkit/src/github.ts
Line 144 in 7b876a9
So we just need to fix the link.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Was looking at people updating to latest v6 of build-push-action and saw this summary generation: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951
Seems like the username/handle is used as secret: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/workflow#L17
And therefore any part of the summary containing the secret value is redacted which breaks
.dockerbuild
link:And global rendering of the summary:
Corrected link is: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534
Which returns the right
.dockerbuild
filename as we upload the object withContent-Disposition
header that is unredacted:actions-toolkit/src/github.ts
Line 144 in 7b876a9
So we just need to fix the link.
The text was updated successfully, but these errors were encountered: