Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary: .dockerbuild link broken #367

Closed
crazy-max opened this issue Jun 17, 2024 · 0 comments · Fixed by #368
Closed

summary: .dockerbuild link broken #367

crazy-max opened this issue Jun 17, 2024 · 0 comments · Fixed by #368
Labels
kind/bug Something isn't working

Comments

@crazy-max
Copy link
Member

crazy-max commented Jun 17, 2024

Was looking at people updating to latest v6 of build-push-action and saw this summary generation: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951

Seems like the username/handle is used as secret: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/workflow#L17

          username: ${{ secrets.DOCKERHUB_USERNAME }}

And therefore any part of the summary containing the secret value is redacted which breaks .dockerbuild link:

https://github.com/***/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534

And global rendering of the summary:

image

Corrected link is: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534

Which returns the right .dockerbuild filename as we upload the object with Content-Disposition header that is unredacted:

blobContentDisposition: `attachment; filename="${artifactName}"`

So we just need to fix the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
1 participant