-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build summary feature doesn't work with GitHub Enterprise Server #1154
Comments
Yes this seems to be the issue, I will look if we can downgrade to v1. |
Downgrading to v1 does not look promising as we can't interact with azure blob storage API anymore, which is needed in our case to set appropriate content-disposition header when uploading the artifact: https://github.com/docker/actions-toolkit/blob/2e70a0cac6b3a7fad73b736a8fc017036b1b082f/src/github.ts#L154-L173 In the meantime we will print a better error message for GHES users: docker/actions-toolkit#382 @dvdksn Could we add a callout in https://docs.docker.com/build/ci/github-actions/build-summary/ page saying that Build summary is not yet supported on GHES? |
@crazy-max Thank you for your work!! Setting "DOCKER_BUILD_SUMMARY" would help, but it is cumbersome to set it for our all workflows. Stop using Annotations and just show them in the actions log. What do you think of this? |
@ponkio-o Should be good with latest release https://github.com/docker/build-push-action/releases/tag/v6.7.0 |
Not 100% sure - but Build Summary is working on GHES - at least I'm on 3.12.x and a simple hello world is possible. Looking at the changelog, the build summary was introduced in GHES 3.6 - so it's there since 2022-07-26. So while the last version without Build Summary (3.5) was retired on 2023-09-25, the Build Summary should be seen as general available also on GHES. |
It's not about the build summary itself but the actions artifact lib v2 that is not supported on GHES: https://github.com/actions/toolkit/tree/main/packages/artifact#v2---whats-new
|
Could we make it work if |
This is tracked in github/roadmap#930 (Q4 2024) |
Yes but then only summary will be available without the |
Contributing guidelines
I've found a bug, and:
Description
Build Summary introduced in v6.0.0 doesn't work with GHES v3.11.7.
My guess is that it is because the artifact v2 library used internally does not support GHES.
Expected behaviour
Correctly working build summary.
Actual behaviour
The following error message on
Post Build and push
step.Repository URL
No response
Workflow run URL
No response
YAML workflow
Workflow logs
BuildKit logs
No response
Additional info
GitHub Enterprise Server: v3.11.7
actions/runner: v2.317.0
The text was updated successfully, but these errors were encountered: