Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Golang 1.12.4 #1833

Closed

Conversation

tao12345666333
Copy link
Contributor

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

- What I did

go1.12.4 (released 2019/04/11) fixes an issue where using the prebuilt binary.

golang/go@go1.12.3...go1.12.4

The issue golang/go#31293 has been fixed and closed now.

And docker/golang-cross:1.12.4 image has been published after docker/golang-cross#28 👍

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Contributor Author

duplicate #1832 , close this.

@thaJeztah
Copy link
Member

😅 I see you were only 3 minutes later than I, so close 😂 🤗 ❤️

@tao12345666333
Copy link
Contributor Author

I looked at the PR list after submitting the PR. I found your submission, so I closed this. 😉

@thaJeztah
Copy link
Member

Or, ....you could discover that you already did exactly the same PR yourself, but forgot about it, because it was months ago 😂😳☺️ moby/swarmkit#2698 (comment)

@tao12345666333
Copy link
Contributor Author

Hah, there is indeed such a situation, thank you for your work ❤️ and there are too many projects to be maintained.

@thaJeztah
Copy link
Member

Thank you for helping; it's really appreciated 👍

@tao12345666333
Copy link
Contributor Author

I am very happy to be involved in the project. Thank you for your guidance and help. ❤️
I hope to participate more deeply in the project and contribute in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants