Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker COPY doesn't work properly for symlinks using Fig #651

Closed
petercv opened this issue Nov 17, 2014 · 2 comments
Closed

Docker COPY doesn't work properly for symlinks using Fig #651

petercv opened this issue Nov 17, 2014 · 2 comments

Comments

@petercv
Copy link

petercv commented Nov 17, 2014

See this Docker issue:
moby/moby#8801

Might be a Fig issue, because plain docker doesn't seem to have this issue.

A test-case can be found here:
https://github.com/felixdv/docker-fig-symlink-testcase

@petercv
Copy link
Author

petercv commented Nov 19, 2014

I think I found the origin of the bug. I've traced it back to the docker/docker-py repository. The docker-py client is used by fig to build the various images. The docker-py client creates a tar archive of the build directory which is then uploaded to docker using the REST API. My suspicion is that the tar method doesn't properly handle symlinks like the normal docker client does (see https://github.com/docker/docker-py/blob/master/docker/utils/utils.py). I'm not a Python developer, but I'm gonna try fit it anyway.

@petercv
Copy link
Author

petercv commented Nov 19, 2014

There was indeed a bug in docker-py, however it was already fixed in version 0.6.0. So I've created a pull request that updates the requirements to include docker-py 0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants