reference: move match function to helpers #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update match function to operate on familiar names Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
|
LGTM |
Current coverage is 51.20% (diff: 100%)@@ master #2143 diff @@
==========================================
Files 125 125
Lines 11433 11432 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6996 5854 -1142
- Misses 3550 4832 +1282
+ Partials 887 746 -141
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update match function to operate on familiar names and moved into helpers. The match function is only used against familiar input, not currently a use for a normalized form of the function. Like
IsNameOnly, this is only a helper and does not provide any functionality that could not be achieved by a package importer.