Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Restore vendor directory after dep-validate #2218

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

aaronlehmann
Copy link
Contributor

Currently, this target makes changes to the vendor directory, which may
overwrite local changes or cause build errors. It's better to restore
the original vendor directory after running the check.

Currently, this target makes changes to the vendor directory, which may
overwrite local changes or cause build errors. It's better to restore
the original vendor directory after running the check.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@dmcgowan
Copy link
Collaborator

LGTM

@codecov
Copy link

codecov bot commented Mar 20, 2017

Codecov Report

Merging #2218 into master will decrease coverage by 10.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2218       +/-   ##
===========================================
- Coverage   61.74%   51.72%   -10.02%     
===========================================
  Files         125      125               
  Lines       11452    11452               
===========================================
- Hits         7071     5924     -1147     
- Misses       3495     4782     +1287     
+ Partials      886      746      -140
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-57.23%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.58% <0%> (-56.31%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-50.76%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e5cd5...299b90b. Read the comment docs.

@dmcgowan dmcgowan merged commit 11c74e0 into distribution:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants