Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyword format for downstream docs #2431

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Fix keyword format for downstream docs #2431

merged 1 commit into from
Nov 23, 2017

Conversation

mdlinville
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 20, 2017

Codecov Report

Merging #2431 into master will decrease coverage by 9.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
- Coverage   60.34%   50.74%   -9.61%     
==========================================
  Files         126      126              
  Lines       14436    14436              
==========================================
- Hits         8712     7325    -1387     
- Misses       4841     6367    +1526     
+ Partials      883      744     -139
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.32% <0%> (-66.13%) ⬇️
registry/storage/driver/oss/oss.go 0.45% <0%> (-56.5%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.07% <0%> (-55.4%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.4% <0%> (-52.4%) ⬇️
registry/client/transport/transport.go 68.75% <0%> (-13.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3800056...fda42e5. Read the comment docs.

@@ -1,7 +1,7 @@
---
title: "HTTP API V2"
description: "Specification for the Registry API."
keywords: ["registry, on-prem, images, tags, repository, distribution, api, advanced"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to hit the template, as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, done.

Signed-off-by: Misty Stanley-Jones <misty@docker.com>
@stevvooe
Copy link
Collaborator

@mstanleyjones Are you sure these aren't supposed to be ["registry", "foo", "bar", ...]?

@mdlinville
Copy link
Contributor Author

99.9% sure. @johndmulhausen PTAL

@stevvooe
Copy link
Collaborator

LGTM

@mdlinville
Copy link
Contributor Author

I'm not authorized to merge. :) Let me open the cherry-pick PR too.

@stevvooe stevvooe merged commit 1503fa2 into distribution:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants