add autoredirect auth config #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidswu
force-pushed
the
autoredirect
branch
from
e9b5b9c
to
a0f8018
Compare
caervs
approved these changes
Sep 13, 2018
| func (ac authChallenge) challengeParams(r *http.Request) string { | ||
| var realm string | ||
| if ac.autoRedirect { | ||
| realm = fmt.Sprintf("https://%s/auth/token", r.Host) |
There was a problem hiding this comment.
Doesn't have to be in this change but I'd prefer we use a url.URL object to build this out.
|
Can you rebase to see if it fixes travis? |
It redirects the user to to the Host header's domain whenever they try to use token auth. Signed-off-by: David Wu <david.wu@docker.com>
davidswu
force-pushed
the
autoredirect
branch
from
a0f8018
to
af2be11
Compare
Signed-off-by: David Wu <david.wu@docker.com>
davidswu
force-pushed
the
autoredirect
branch
from
af2be11
to
b2bd465
Compare
|
Please sign your commits following these rules: $ git clone -b "autoredirect" git@github.com:davidswu/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354379144
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
davidswu
force-pushed
the
autoredirect
branch
from
f29e6e8
to
319b2f5
Compare
Signed-off-by: David Wu <david.wu@docker.com>
davidswu
force-pushed
the
autoredirect
branch
from
319b2f5
to
2e1e630
Compare
dmp42
approved these changes
Sep 26, 2018
|
@dmcgowan wdyt? |
|
LGTM I would like to consider a follow up here that allowed templating of the auto redirect realm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It redirects the user to to the Host header's domain whenever they try to use
token auth.
Signed-off-by: David Wu david.wu@docker.com
Originally from #2630