Add release notes for 2.7.0 release candidates #2721
Conversation
dmcgowan
force-pushed
the
release-notes-2.7.0-rc
branch
from
d4bf942
to
a2a3542
Compare
|
Sakeven Jiang |
|
Just mlmhl |
| Yu Wang <yuwa@microsoft.com> Yu Wang (UC) <yuwa@microsoft.com> | ||
| Olivier Gambier <olivier@docker.com> dmp <dmp@loaner.local> | ||
| Olivier Gambier <olivier@docker.com> Olivier <o+github@gambier.email> | ||
| Olivier Gambier <olivier@docker.com> Olivier <dmp42@users.noreply.github.com> |
There was a problem hiding this comment.
Damn. This dude is obnoxious :-) ^
There was a problem hiding this comment.
Yeah. Who does he think he is? 😄
|
LGTM |
|
Just uhayate. Thanks. |
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
dmcgowan
force-pushed
the
release-notes-2.7.0-rc
branch
from
a2a3542
to
2eb7a17
Compare
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
=======================================
Coverage 60.28% 60.28%
=======================================
Files 103 103
Lines 8003 8003
=======================================
Hits 4825 4825
Misses 2536 2536
Partials 642 642
Continue to review full report at Codecov.
|
| Yu Wang <yuwa@microsoft.com> Yu Wang (UC) <yuwa@microsoft.com> | ||
| Olivier Gambier <olivier@docker.com> dmp <dmp@loaner.local> | ||
| Olivier Gambier <olivier@docker.com> Olivier <o+github@gambier.email> | ||
| Olivier Gambier <olivier@docker.com> Olivier <dmp42@users.noreply.github.com> |
There was a problem hiding this comment.
Yeah. Who does he think he is? 😄
| Stephen J Day <stephen.day@docker.com> Stephen Day <stevvooe@gmail.com> | ||
| Olivier Gambier <olivier@docker.com> Olivier Gambier <dmp42@users.noreply.github.com> | ||
| Brian Bland <brian.bland@docker.com> Brian Bland <r4nd0m1n4t0r@gmail.com> | ||
| Stephen J Day <stephen.day@docker.com> Stephen Day <stevvooe@users.noreply.github.com> |
There was a problem hiding this comment.
Non-blocking: This might be a result of tooling used to generate this file but is it ok to provide github.com email address since it is not read?
There was a problem hiding this comment.
Not quite sure I follow. This file is manually created, as opposed to a file like AUTHORS which tends to be generated. This file is formatted to have a single name/email for each individual which has multiple name/email author lines in the git history. In a perfect world everyone has their user.email and user.name git configs set to an email which never changes and their real name, and maybe we have entries for maintainers who merge but have github configured to use their no reply email. It is in the contributing docs that real names must be used, but that is hard to enforce on every PR since there is no real way to automate that, the mailmap attempts to clean that up. Unfortunately after we merge there is also no way we can force someone to provide their real name if they didn't before we merged their commit.
There was a problem hiding this comment.
Cool. Completely agreed with your points. Since this file is created manually do you it is too much to ask to remove no-reply email address since another email of the same user is also there in the file? I am completely ok leaving it like this.
This is following containerd's release format, using the same release tool and toml template. This file will be used for all 2.7.0 RCs.
Generated notes https://gist.github.com/dmcgowan/f081d53a8c674dccd1a742b685195ba0
Updated mailmap, please let me know if you want your name displayed differently
@fate-grand-order @mlmhl @sakeven @uhayate @liyongxin