Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] default autoredirect to false #2802

Merged
merged 1 commit into from
Jan 7, 2019
Merged

[2.7] default autoredirect to false #2802

merged 1 commit into from
Jan 7, 2019

Conversation

davidswu
Copy link
Contributor

@davidswu davidswu commented Jan 4, 2019

2.7 port for #2800

Signed-off-by: David Wu david.wu@docker.com

default autoredirect to false
caf43bb 
Signed-off-by: David Wu <david.wu@docker.com>
@davidswu davidswu added this to the Registry/2.7.1 milestone Jan 4, 2019
@davidswu davidswu changed the title default autoredirect to false [2.7] default autoredirect to false Jan 4, 2019
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #2802 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2802      +/-   ##
==========================================
+ Coverage   60.24%   60.25%   +<.01%     
==========================================
  Files         103      103              
  Lines        8022     8024       +2     
==========================================
+ Hits         4833     4835       +2     
  Misses       2546     2546              
  Partials      643      643
Flag Coverage Δ
#linux 60.25% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
registry/auth/token/accesscontroller.go 66.16% <66.66%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b7b58...caf43bb. Read the comment docs.

dmp42
dmp42 approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@dmp42 dmp42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caervs
caervs approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caervs
caervs previously requested changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooop, actually @davidswu I think you meant to submit this PR against the release/2.7 branch.

@davidswu davidswu changed the base branch from master to release/2.7 January 7, 2019 17:18
@davidswu
Copy link
Contributor Author

davidswu commented Jan 7, 2019

@caervs changed

dmcgowan
dmcgowan approved these changes Jan 7, 2019
View reviewed changes
Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit e702d95 into distribution:release/2.7 Jan 7, 2019
@thaJeztah
Copy link
Member

This was included in the v2.7.1 release; could someone update the milestone accordingly? https://github.com/docker/distribution/blob/v2.7.1/registry/auth/token/accesscontroller.go#L165-L172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@dmp42 dmp42 dmp42 approved these changes

@caervs caervs caervs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Registry/2.7.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidswu @thaJeztah @dmcgowan @dmp42 @caervs