Use same env var in Dockerfile and Makefile #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "ISS-2819" git@github.com:caervs/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Ensures that build tags get set in the Dockerfile so that OSS and GCS drivers are built into the official registry binary. Closes distribution#2819 Signed-off-by: Ryan Abrams <rdabrams@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release/2.7 #2821 +/- ##
============================================
Coverage 60.25% 60.25%
============================================
Files 103 103
Lines 8024 8024
============================================
Hits 4835 4835
Misses 2546 2546
Partials 643 643
Continue to review full report at Codecov.
|
davidswu
approved these changes
Jan 16, 2019
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Apr 9, 2019
This commit is to build a regsitry bases on v2.7.1 code and introduces an fix on issue goharbor#2819, this is a P0 bug on v2.7.1 which causes GCS doesn't work well on v2.7.1 For more details, refer to distribution/distribution#2821 Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Apr 9, 2019
This commit is to build a regsitry bases on v2.7.1 code and introduces an fix on issue goharbor#2819, this is a P0 bug on v2.7.1 which causes GCS doesn't work well on v2.7.1 For more details, refer to distribution/distribution#2821 Signed-off-by: wang yan <wangyan@vmware.com>
|
Looks like this was made directly against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that build tags get set in the Dockerfile so that OSS and GCS drivers
are built into the official registry binary.
Closes #2819
Signed-off-by: Ryan Abrams rdabrams@gmail.com