Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[17.06] Limit max backoff delay to 2 seconds for GRPC connection #94

Merged
merged 1 commit into from
Jul 12, 2017
Merged

[17.06] Limit max backoff delay to 2 seconds for GRPC connection #94

merged 1 commit into from
Jul 12, 2017

Conversation

andrewhsu
Copy link
Contributor

Backport fix:

@moypray @andrewhsu
Limit max backoff delay to 2 seconds for GRPC connection
fbc1b30 
Docker use default GRPC backoff strategy to reconnect to containerd when
connection is lost. and the delay time grows exponentially, until reaches 120s.

So Change the max delay time to 2s to avoid docker and containerd
connection failure.

Signed-off-by: Wentao Zhang <zhangwentao234@huawei.com>
(cherry picked from commit d3d8c77)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
thaJeztah
thaJeztah approved these changes Jul 4, 2017
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ping @mlaventure @stevvooe

@stevvooe
Copy link
Contributor

stevvooe commented Jul 5, 2017

LGTM

@thaJeztah
Copy link
Member

@andrewhsu looks ready to merge

@andrewhsu andrewhsu merged commit 75ef04b into docker-archive:17.06 Jul 12, 2017
@andrewhsu andrewhsu deleted the fix-grpc branch July 12, 2017 01:59
@andrewhsu andrewhsu modified the milestone: 17.06.1 Jul 12, 2017
docker-jenkins pushed a commit that referenced this pull request Oct 23, 2018
@andrewhsu
Merge pull request #94 from dperny/18.09-bump-swarmkit
1a55d34 
[18.09 Backport] Bump swarmkit to c82e409d
Upstream-commit: 8d624c31dd25814272117bbdd908a4414e636aed
Component: engine
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Feb 3, 2020
@andrewhsu
Merge pull request docker-archive#94 from andrewhsu/fix-grpc
6fa91f3 
[17.06] Limit max backoff delay to 2 seconds for GRPC connection
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.06.1
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewhsu @stevvooe @thaJeztah @moypray