Carry#13921 : Expand /info: Expose OSType (GOOS), Architecture (GOARCH) #17478
Conversation
| ProcessorArchitectureArm = 5 // PROCESSOR_ARCHITECTURE_ARM | ||
| ) | ||
|
|
||
| var sysinfo systeminfo |
There was a problem hiding this comment.
:-1 where do you define systeminfo ? you need to import
vdemeester
force-pushed
the
pr-13921
branch
2 times, most recently
from
fd374e1
to
b04c2f8
Compare
|
/ping @tiborvass updated with a |
|
LGTM |
|
LGTM |
|
|
||
| func init() { | ||
| var err error | ||
| Architecture, err = architecture.GetRuntimeArchitecture() |
There was a problem hiding this comment.
@vdemeester sorry i was thinking we remove the pkg/parsers/architecture package and just have all that logic in pkg/platform here. WDYT?
There was a problem hiding this comment.
I was wondering about that too, so sound good to me, will try to do it 😉.
- introduces Swarm-relevant keys, see moby#13634 - docs updated Signed-off-by: Olle Jonsson <olle.jonsson@gmail.com>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
|
@tiborvass done 😇 |
|
|
||
| func init() { | ||
| var err error | ||
| Architecture, err = GetRuntimeArchitecture() |
There was a problem hiding this comment.
oh gosh, last thing and then i promise i'll merge: we don't need to export this, and I don't find it idiomatic to prefix with Get, so i suggest renaming this to runtimeArchitecture() but feel free to protest.
Other than that, it's good to go
|
LGTM |
Carry#13921 : Expand /info: Expose OSType (GOOS), Architecture (GOARCH)
These changes were made as part of moby#17478 but inadvertently added to the v1.21 API version. Also added a short description to the API changelog. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This carry #13921 from 🌟 @olleolleolle to add
OSTypeandArchitectureto/infoendpoint.Trying to take into account the comment from @tiborvass in here : #13921 (comment)
/me hopes it builds on other platform
🌟 @tiborvass @runcom