Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HostConfig at API container start #17799

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

runcom
Copy link
Member

@runcom runcom commented Nov 8, 2015

@runcom
Copy link
Member Author

runcom commented Nov 8, 2015

Unluckily, adding a deprecation notice in API response requires modifying the returned status code or add content to a 204 no-content response. I hope the deprecation notice here will suffice.

@@ -12,6 +12,14 @@ parent = "mn_use_docker"

The following list of features are deprecated.

### HostConfig at API container start
**Deprecated In Release: v1.9**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, don't think we can add this, now that 1.9 was released? @tiborvass wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, just copy pasted, it should be 1.10

@LK4D4
Copy link
Contributor

LK4D4 commented Nov 13, 2015

LGTM

@thaJeztah thaJeztah added this to the 1.10 milestone Nov 15, 2015
@thaJeztah
Copy link
Member

ping @cpuguy83 does this LGTY?

@cpuguy83
Copy link
Member

LGTM

ping @vieux @aluzzardi

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom
Copy link
Member Author

runcom commented Nov 20, 2015

rebased!

@calavera
Copy link
Contributor

LGTM

calavera added a commit that referenced this pull request Nov 25, 2015
Deprecate HostConfig at API container start
@calavera calavera merged commit ad67f32 into moby:master Nov 25, 2015
@runcom runcom deleted the deprecate-hc-cont-start branch November 25, 2015 17:14
@aluzzardi
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate hostConfig on start for API > 1.21
7 participants