-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate HostConfig at API container start #17799
Conversation
Unluckily, adding a deprecation notice in API response requires modifying the returned status code or add content to a 204 no-content response. I hope the deprecation notice here will suffice. |
@@ -12,6 +12,14 @@ parent = "mn_use_docker" | |||
|
|||
The following list of features are deprecated. | |||
|
|||
### HostConfig at API container start | |||
**Deprecated In Release: v1.9** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, don't think we can add this, now that 1.9 was released? @tiborvass wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, just copy pasted, it should be 1.10
4f726ae
to
32e1d9e
Compare
LGTM |
ping @cpuguy83 does this LGTY? |
LGTM ping @vieux @aluzzardi |
32e1d9e
to
bebb2e1
Compare
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
bebb2e1
to
3e7405a
Compare
rebased! |
LGTM |
Deprecate HostConfig at API container start
👍 |
Signed-off-by: Antonio Murdaca runcom@redhat.com