[Carry 17414] Added additional container information to "docker info". #19249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just showing the number of containers this patch will show the number of running, paused and stopped containers as well. Signed-off-by: Kim Eik <kim@heldig.org> (cherry picked from commit a9804ab)
This was referenced Jan 12, 2016
|
Vendoring is happening in #19243. |
| @@ -112,6 +112,7 @@ This section lists each version from latest to oldest. Each listing includes a | |||
| * `GET /networks` now supports filtering by `name`, `id` and `type`. | |||
| * `POST /containers/create` now allows you to set the static IPv4 and/or IPv6 address for the container. | |||
| * `POST /networks/(id)/connect` now allows you to set the static IPv4 and/or IPv6 address for the container. | |||
| * `GET /info` now includes the number of containers running, stopped and paused. | |||
There was a problem hiding this comment.
should have a comma before and paused. (just a nit)
|
two really tiny nits, LGTM otherwise |
Signed-off-by: David Calavera <david.calavera@gmail.com>
|
fixed. |
|
LGTM moving to "merge", taking previous LGTM's from #17414 into account |
|
😭 janky, nooooo
|
runcom
added a commit
that referenced
this pull request
Jan 13, 2016
[Carry 17414] Added additional container information to "docker info".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry #17414.
WAIT BEFORE MERGE: This PR is blocked by docker/engine-api#36