Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[18.09 backport] Windows:Allow process isolation #81

Merged

Conversation

thaJeztah
Copy link
Member

backport of moby#38000 for 18.09

fixes moby#27524
fixes moby#37873
fixes docker/for-win#1822
closes moby#37065
closes moby#27730

git checkout -b 18.09_backport_processandiot ce-engine/18.09
git cherry-pick -s -S -x c907c2486c0850030f8ac1819ac8c87631472c68

cherry-pick was clean, no conflicts

Signed-off-by: John Howard <jhoward@microsoft.com>
(cherry picked from commit c907c24)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.09.0 milestone Oct 11, 2018
@thaJeztah
Copy link
Member Author

ping @andrewhsu PTAL

@chlowell
Copy link

chlowell commented Nov 7, 2018

@thaJeztah will this make it into 18.09?

@thaJeztah
Copy link
Member Author

@chlowell unfortunately, it did not make it for the 18.09.0 release (QA was already too far into verifying the release), but there probably will be a 18.09.1 patch release and, if approved, it may find its way into that release.

@thaJeztah thaJeztah modified the milestones: 18.09.0, 18.09.1 Nov 8, 2018
@justincormack
Copy link

@t0p4 what error message do you get? You need to run a container with a 1809 base image, I think some should be available now.

@t0p4
Copy link

t0p4 commented Nov 14, 2018

cool solution, it's work

Copy link

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit a1f6b04 into docker-archive:18.09 Nov 27, 2018
@thaJeztah thaJeztah deleted the 18.09_backport_processandiot branch November 27, 2018 18:06
@ksanchez15
Copy link

Does it mean that on windows 1809 it will be possible to run any container based on previous windows server images (2016, 1709, etc) in process isolation mode?

@thaJeztah
Copy link
Member Author

No, process isolation requires the base image to match the host version of Windows (this is due to Windows not having a stable kernel API)

@ksanchez15
Copy link

ksanchez15 commented Dec 7, 2018

@thaJeztah ok and this means i could have windows 10 1709 and run a container windows servercore 1709 rght?

@nelsonjchen
Copy link

Does this work in Windows 10 Home? I'm kind of curious.

@thaJeztah
Copy link
Member Author

@nelsonjchen Windows 10 Home is not supported for Docker Desktop (requires "pro"), nor Docker EE, so not sure if it will run ok (i.e., it's untested).

@thaJeztah
Copy link
Member Author

@lesanchez I think that works yes (but disclaimer: I'm not on Windows myself, so take it with a grain of salt 😅)

@justincormack
Copy link

@nelsonjchen we don't know, also kind of curious, it may still require other pieces that are not shipped in Home but I don't know anyone who has tried it yet.

@ksanchez15
Copy link

@thaJeztah Thanks!

@nelsonjchen
Copy link

🔨 ⚰️

Windows 10 Home 1809 doesn't have the containers feature that can be installed like Pro. That was expected. I guess that's that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants