-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default-address-pools can not be specified in configuration #3108
Comments
@andrewyager try |
Same issue with default-address-pool. |
I'm using |
Is there an equivalent option in Docker for Mac? Happy to change it, however I don't think you can add additional arguments to the engine startup? |
@andrewyager Your JSON config is invalid, remove the last comma |
The perils of not copy-pasting and retyping. This is invalid according to the validator {
"debug" : true,
"experimental" : true,
"default-address-pool": [
{
"base": "10.225.0.0/16",
"size": 24
}]
} This is also invalid: {
"debug" : true,
"experimental" : true,
"default-address-pools": [
{
"base": "10.225.0.0/16",
"size": 24
}]
} The config linter in the docker for mac toolbox does not understand either of these parameter options. |
I'm not using Docker for Mac, I'm on Ubuntu 16.04 and this config works:
|
Yes. I suspect the issue is specific to docker-for-mac, rather than docker itself which is why the issue is posted in the docker/for-mac tree! |
You can bypass the GUI for configuring The ability to edit Here's my
|
The above process works 100%. The issue then remains the originally reported one, namely that the docker-for-mac GUI doesn't correctly validate the configuration option, even though it is supported and will need to be updated. |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so. Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows. |
Just chiming in that this issue is still around in Docker For Mac 2.0.0.0-mac78. |
/lifecycle frozen |
I was able to paste a daemon.json config with pools into the Docker for Mac GUI using version 2.0.0.2 (30215) today. Verified by deleting my ~/.docker/daemon.json and restarting Docker. |
Looks like this option is completely missing in windows server version. |
I just went back and looked into the code. I don't see any windows specific restriction for this feature. I feel it is possible. |
Not supported on windows : the following directives don't match any configuration option: default-address-pools |
Same here, using Docker on Windows and default-address-pools is not recognized. Is there any workaround yet? |
Expected behavior
According to the milestone release, default-address-pools should be supported in the 18.06 release (docker/cli#818, moby/moby#36396)
Actual behavior
Docker For Mac will not validate and accept this in the configuration
Information
Diagnostic logs
Steps to reproduce the behavior
displays:
The text was updated successfully, but these errors were encountered: