Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token update --set-active=false is quite confusing #66

Closed
justincormack opened this issue Oct 19, 2020 · 2 comments · Fixed by #138
Closed

token update --set-active=false is quite confusing #66

justincormack opened this issue Oct 19, 2020 · 2 comments · Fixed by #138
Labels
enhancement New feature or request

Comments

@justincormack
Copy link
Member

maybe we could just have "activate" and "deactivate" flags? Not every user understands Go's CLI conventions for true and false, they are not common in other languages.

@silvin-lubecki
Copy link
Collaborator

Maybe we could also dump the update command (updating the description may not be worth it, and I guess we don't want to update the scope afterwards either), and replace with 2 commands activate and deactivate ?

$ hub-tool token activate XXXXX-XXX-XXX-XXXX
XXXXX-XXX-XXX-XXXX is active
$ hub-tool token deactivate XXXXX-XXX-XXX-XXXX
XXXXX-XXX-XXX-XXXX is inactive

WDYT?

@silvin-lubecki silvin-lubecki added the enhancement New feature or request label Oct 20, 2020
@justincormack
Copy link
Member Author

Yes thats much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants