Change debug phrasing for pkcs11 initialization failure #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thank you - this message is less scary looking :) |
|
Given we know what it means, would it make sense to make it even more user friendly and just say something like "No Yubikey found, using alternative key storage." |
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
riyazdf
force-pushed
the
pkcs11-debug-msg
branch
from
2b53a11
to
7d2b225
Compare
|
@endophage I like that messaging better, updated 👍 |
|
Cool, LGTM! |
|
Before merging, as you'd already LGTM'd the initial message, @cyli: any thoughts on the updated message? |
|
That's definitely even less scary than the previous message. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to our debug statement for when we fail to initialize a PKCS11 environment, since this is a common source of confusion.
Signed-off-by: Riyaz Faizullabhoy riyaz.faizullabhoy@docker.com