Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change debug phrasing for pkcs11 initialization failure #891

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

riyazdf
Copy link
Contributor

@riyazdf riyazdf commented Aug 1, 2016

Small update to our debug statement for when we fail to initialize a PKCS11 environment, since this is a common source of confusion.

Signed-off-by: Riyaz Faizullabhoy riyaz.faizullabhoy@docker.com

@cyli
Copy link
Contributor

cyli commented Aug 1, 2016

LGTM! Thank you - this message is less scary looking :)

@endophage
Copy link
Contributor

Given we know what it means, would it make sense to make it even more user friendly and just say something like "No Yubikey found, using alternative key storage."

Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
@riyazdf
Copy link
Contributor Author

riyazdf commented Aug 1, 2016

@endophage I like that messaging better, updated 👍

@endophage
Copy link
Contributor

Cool, LGTM!

@endophage
Copy link
Contributor

Before merging, as you'd already LGTM'd the initial message, @cyli: any thoughts on the updated message?

@cyli
Copy link
Contributor

cyli commented Aug 1, 2016

That's definitely even less scary than the previous message. 👍

@endophage endophage merged commit e6e7af5 into master Aug 1, 2016
@riyazdf riyazdf deleted the pkcs11-debug-msg branch August 1, 2016 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants