Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

add support for docker ps -l / -n #468

Merged
merged 1 commit into from
Mar 10, 2015
Merged

add support for docker ps -l / -n #468

merged 1 commit into from
Mar 10, 2015

Conversation

vieux
Copy link
Contributor

@vieux vieux commented Mar 10, 2015

Fix #426

@vieux
add support for docker ps -l / -n
328b9ae 
Signed-off-by: Victor Vieux <vieux@docker.com>
@vieux
Copy link
Contributor Author

vieux commented Mar 10, 2015

ping @aluzzardi, can you also take a look at the tests.

Thanks

aluzzardi
aluzzardi reviewed Mar 10, 2015
View reviewed changes
api/api.go
@@ -117,12 +118,13 @@ func getContainersJSON(c *context, w http.ResponseWriter, r *http.Request) {
}

all := r.Form.Get("all") == "1"
limit, _ := strconv.Atoi(r.Form.Get("limit"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when no limit is provided? Does it default to 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@aluzzardi
Copy link
Contributor

Minor comments (probably useless), otherwise LGTM

vieux added a commit that referenced this pull request Mar 10, 2015
@vieux
Merge pull request #468 from vieux/ps_n_l
7945e0a 
add support for docker ps -l / -n
@vieux vieux merged commit 7945e0a into docker-archive:master Mar 10, 2015
@vieux vieux deleted the ps_n_l branch March 10, 2015 23:42
@vieux vieux removed the in progress label Mar 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker ps -l shows last *running* container
2 participants
@vieux @aluzzardi