This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Enable profiling over HTTP in debug mode #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
|
LGTM |
|
LGTM. |
|
Cool! I've never seen this before. Why no |
|
@MHBauer What do you mean? |
|
@aluzzardi maybe I am looking in the wrong place, but I see one more function called Trace, here. Again, I know very little about this whole profiling thing in the first place, so maybe there was a reason you left it off. |
| r.HandleFunc("/pprof/heap", pprof.Handler("heap").ServeHTTP) | ||
| r.HandleFunc("/pprof/goroutine", pprof.Handler("goroutine").ServeHTTP) | ||
| r.HandleFunc("/pprof/threadcreate", pprof.Handler("threadcreate").ServeHTTP) | ||
| } |
There was a problem hiding this comment.
r.HandleFunc("/debug/pprof/trace", pprof.Trace)
There was a problem hiding this comment.
Yes, exactly this. I probably should have done this by example like you did. If there is a reason to not expose it, that's fine. Don't let me hold up the merge.
There was a problem hiding this comment.
It's new in go 1.5.x, I added a commit to the PR
Signed-off-by: Victor Vieux <vieux@docker.com>
|
LGTM |
vieux
added a commit
that referenced
this pull request
Dec 8, 2015
Enable profiling over HTTP in debug mode
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
Enable profiling over HTTP in debug mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrea Luzzardi aluzzardi@gmail.com