allocator: Update unallocatedServices properly after service updates #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a service update caused the service to be successfully allocated, that service should be removed from unallocatedServices. If the allocation was unsuccessful, unallocatedServices should be updated to contain the latest version of the service. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2020 +/- ##
=========================================
+ Coverage 53.66% 53.76% +0.1%
=========================================
Files 109 109
Lines 18991 18994 +3
=========================================
+ Hits 10191 10213 +22
+ Misses 7578 7545 -33
- Partials 1222 1236 +14Continue to review full report at Codecov.
|
|
This looks just right. Initially I was thinking the call to would eventually take care of updating the allocated/unallocated services map, but that is only for the services which need to be allocated and succeeds to be allocated at the time that event comes, as I was able to understand with @aaronlehmann offline. |
|
Looks good to me |
|
LGTM |
This was referenced Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a service update caused the service to be successfully allocated, that service should be removed from
unallocatedServices.If the allocation was unsuccessful,
unallocatedServicesshould be updated to contain the latest version of the service.cc @alexmavr @yongtang @aboch