provider: adjust credential logic for hub-stage #45
Conversation
|
(based on some other uses of docker/login-action i saw in the org for using hub-stage) |
Signed-off-by: Nick Santos <nick.santos@docker.com>
| @@ -23,7 +23,4 @@ func testAccPreCheck(t *testing.T) { | |||
| if v := os.Getenv("DOCKER_USERNAME"); v == "" { | |||
There was a problem hiding this comment.
can't expect DOCKER_USERNAME to be set either with the new auth method
There was a problem hiding this comment.
ya...i hit this too.
the way that the AWS provider handles this is that there's a aws_caller_identity data resource
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/caller_identity
and then you'd use that in the acceptance tests, rather than pulling from DOCKER_USERNAME. what do you think?
There was a problem hiding this comment.
yeah i like that, do you know any api's off the top of your head that could get us that info?
There was a problem hiding this comment.
well, for the base case, we don't need to even call any apis, the provider can return what it has 😛
#46
|
acceptance test run with this change - https://github.com/docker/terraform-provider-docker/actions/runs/10601181940 |
Signed-off-by: Nick Santos nick.santos@docker.com