-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the search error after setting the ID in the title #1159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After tests , the normal cases work fine. 👍
A little problem(maybe it is not a problem), when the id settings like :id=xxx%xxx
( including the %
) , it will get this issues #1118 again.
cuz, at thegetAndRemoveConfig()
.replace(/(?:^|\s):([\w-]+:?)=?([\w-%]+)?/g, (m, key, value) => {
we allowed the %
for getting the resizing params , such as ':size=10%'
.
this util relates to lots of configurations and makes things broken sometimes. 😅
At the same time, when the id config has some weird characters, this settings would broken also.
If possible, I glad to see this regex in getAndRemoveConfig()
will be refined soon, or there would have better solution instead.
The Since I couldn't use local git commits directly, I changed one less place and now I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.:+1:
@sy-records thanks for the PR. 💯 just a small point, we are using angular commit convention so the commit message format should match these guidelines. |
okey. |
Summary
Fix the id set in the title, resulting in wrong link when searching.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
lib
directory.