Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint fixes for the project #987

Closed
5 tasks
anikethsaha opened this issue Dec 23, 2019 · 3 comments · Fixed by #989
Closed
5 tasks

Eslint fixes for the project #987

anikethsaha opened this issue Dec 23, 2019 · 3 comments · Fixed by #989

Comments

@anikethsaha
Copy link
Member

anikethsaha commented Dec 23, 2019

After adding eslint, if your run npx eslint . it will show huge number of errors and warning.

This issue is to fix those errors and warning and remove/add eslint rules if required after discussing here.

Also, eslint script and .eslintignore should be configured as follows.

package.json

"lint": "eslint . --fix",

.eslintrc

{
  "extends": "xo-space/browser",
  "rules": {
    "semi": [2, "never"],
    "no-return-assign": "off",
    "no-unused-expressions": "off",
    "no-new-func": "off",
    "no-multi-assign": "off",
    "no-mixed-operators": "off",
    "max-params": "off",
    "no-script-url": "off",
    "camelcase": "off",
    "object-curly-spacing": "off",
    "no-warning-comments": "off",
    "no-negated-condition": "off",
    "eqeqeq": "warn",
    "no-eq-null": "warn",
    "max-statements-per-line": "warn"
  },
  "globals": {
    "Docsify": true,
    "$docsify": true,
    "process": true
  },
  "env": {
    "browser": true,
    "amd": true,
    "node": true
  }
}
  • Npm script fix
  • .eslintrc refactore
  • Errors fix
  • Warning fix
  • add the linting to travis

Contributions are welcome

@IvanFrescas
Copy link

Hi, is anyone working on this issue?

@anikethsaha
Copy link
Member Author

no, feel free to pick this 👍

@giulioambrogi giulioambrogi mentioned this issue Dec 27, 2019
5 tasks
@giulioambrogi
Copy link
Contributor

giulioambrogi commented Dec 27, 2019

Hi @anikethsaha @IvanFrescas I've just opened a PR for this issue #989

@anikethsaha anikethsaha unpinned this issue Dec 31, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants