From d59ff7415060d1d3425547ac06010616a6bbdda3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Thu, 15 Aug 2024 21:23:18 +0200 Subject: [PATCH] Remove quotes In the case of a pull request made from a fork, secrets are not accessible, and this resolved to null. The codecov action seems to interpret null as no secret provided, while it interprets the empty string as an invalid token, making the whole tokenless upload invalid. --- workflow-templates/continuous-integration.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/workflow-templates/continuous-integration.yml b/workflow-templates/continuous-integration.yml index 609ba3f..6a0b445 100644 --- a/workflow-templates/continuous-integration.yml +++ b/workflow-templates/continuous-integration.yml @@ -27,7 +27,7 @@ jobs: with: php-versions: '["6.0", "6.1"]' # Use custom versions of PHP secrets: - CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}" + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} phpunit-unstable-symfony: name: "PHPUnit with unstable Symfony" @@ -39,4 +39,4 @@ jobs: # If the package requires some components but does not allow that version yet extra-requirements: "symfony/framework-bundle 47.1.x symfony/console 47.1.x" secrets: - CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}" + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}