Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Drop support for DoctrineCacheBundle #1029

Merged
merged 1 commit into from
Oct 14, 2019
Merged

[2.0] Drop support for DoctrineCacheBundle #1029

merged 1 commit into from
Oct 14, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Oct 8, 2019

This PR drops previously deprecated support for DoctrineCacheBundle. Caches can be configured with the pool and service types. If no configuration is set, the bundle will automatically use the system pool as metadata cache and the app pool for everything else.

@alcaeus alcaeus added this to the 2.0.0 milestone Oct 8, 2019
@alcaeus alcaeus self-assigned this Oct 8, 2019
dmaicher
dmaicher approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 also quickly tested it on a new skeleton app

@alcaeus alcaeus merged commit 357a477 into doctrine:master Oct 14, 2019
@alcaeus alcaeus deleted the drop-cache-bundle branch October 14, 2019 02:11
@ostrolucky ostrolucky mentioned this pull request Jan 9, 2020
Merged
@alcaeus alcaeus mentioned this pull request Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees

@alcaeus alcaeus

Labels
Improvement
Projects
None yet
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@alcaeus @greg0ire @dmaicher