Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psalm to CI #678

Merged
merged 10 commits into from
Jul 18, 2021
Merged

Add psalm to CI #678

merged 10 commits into from
Jul 18, 2021

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Jul 7, 2021

this PR adds psalm at level 7 and fixes the issues found, symfony/validator and symfony/security-bundle have been added because they are used:

use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntityValidator;

which has a dependency on https://github.com/symfony/doctrine-bridge/blob/ed2e5a8a0987e6484ffac544918e1bd3da7ffb1c/Validator/Constraints/UniqueEntityValidator.php#L15-L18

use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;

depends on https://github.com/symfony/doctrine-bridge/blob/ed2e5a8a0987e6484ffac544918e1bd3da7ffb1c/Validator/Constraints/UniqueEntity.php#L14

And for security, we are using:

use Symfony\Component\Security\Core\User\UserInterface;

use Symfony\Bridge\Doctrine\DependencyInjection\Security\UserProvider\EntityFactory;

which depends on https://github.com/symfony/doctrine-bridge/blob/ed2e5a8a0987e6484ffac544918e1bd3da7ffb1c/DependencyInjection/Security/UserProvider/EntityFactory.php#L14

Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to merge this but despite re-running checks two times I have no clue what's wrong with them

Comment on lines +25 to +26
<!-- Allow 1 direct deprecation until https://github.com/doctrine/DoctrineMongoDBBundle/pull/675 is merged -->
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[direct]=1"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime I've ignored the direct deprecation:

Remaining direct deprecation notices (1)

  1x: The "" service relies on the deprecated "Doctrine\Common\Cache\ArrayCache" class. It should either be deprecated or its implementation upgraded.
    1x in ServiceRepositoryTest::testRepositoryServiceWiring from Doctrine\Bundle\MongoDBBundle\Tests

so this will be fixed in #675

@franmomu franmomu requested a review from malarzm July 18, 2021 06:52
@malarzm malarzm merged commit ca6350c into doctrine:4.4.x Jul 18, 2021
@malarzm
Copy link
Member

malarzm commented Jul 18, 2021

Awesome, thank you @franmomu!

@kbond kbond mentioned this pull request Oct 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants