-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add psalm to CI #678
Add psalm to CI #678
Conversation
It is used in phpdoc
It was removed in Symfony 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to merge this but despite re-running checks two times I have no clue what's wrong with them
<!-- Allow 1 direct deprecation until https://github.com/doctrine/DoctrineMongoDBBundle/pull/675 is merged --> | ||
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[direct]=1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime I've ignored the direct deprecation:
Remaining direct deprecation notices (1)
1x: The "" service relies on the deprecated "Doctrine\Common\Cache\ArrayCache" class. It should either be deprecated or its implementation upgraded.
1x in ServiceRepositoryTest::testRepositoryServiceWiring from Doctrine\Bundle\MongoDBBundle\Tests
so this will be fixed in #675
Awesome, thank you @franmomu! |
this PR adds psalm at level 7 and fixes the issues found,
symfony/validator
andsymfony/security-bundle
have been added because they are used:DoctrineMongoDBBundle/Tests/DependencyInjection/AbstractMongoDBExtensionTest.php
Line 25 in baddc63
which has a dependency on https://github.com/symfony/doctrine-bridge/blob/ed2e5a8a0987e6484ffac544918e1bd3da7ffb1c/Validator/Constraints/UniqueEntityValidator.php#L15-L18
DoctrineMongoDBBundle/Validator/Constraints/Unique.php
Line 7 in baddc63
depends on https://github.com/symfony/doctrine-bridge/blob/ed2e5a8a0987e6484ffac544918e1bd3da7ffb1c/Validator/Constraints/UniqueEntity.php#L14
And for security, we are using:
DoctrineMongoDBBundle/Tests/Fixtures/Security/User.php
Line 9 in 8db802c
DoctrineMongoDBBundle/DoctrineMongoDBBundle.php
Line 16 in 8db802c
which depends on https://github.com/symfony/doctrine-bridge/blob/ed2e5a8a0987e6484ffac544918e1bd3da7ffb1c/DependencyInjection/Security/UserProvider/EntityFactory.php#L14