From 90e098ccad75785841bae51b8acaee7b53be9b07 Mon Sep 17 00:00:00 2001
From: "Alexander M. Turek" <me@derrabus.de>
Date: Thu, 21 Mar 2024 21:30:46 +0100
Subject: [PATCH] Deprecate MariaDB 10.4 and MySQL 5.7 support (#6343)

|      Q       |   A
|------------- | -----------
| Type         | improvement
| Fixed issues | N/A

#### Summary

Let's not carry support for the following old releases over into the
next major.

* MariaDB 10.4 will be EOL three months from now.
* MySQL 5.7 is EOL [since October
2023](https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-44.html).
---
 UPGRADE.md                                 |  7 +++++++
 psalm.xml.dist                             | 11 +++++++++++
 src/Driver/AbstractMySQLDriver.php         | 13 +++++++++++++
 src/Platforms/Keywords/MySQL80Keywords.php |  2 ++
 src/Platforms/MariaDB1052Platform.php      |  2 +-
 src/Platforms/MySQL80Platform.php          |  2 ++
 6 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/UPGRADE.md b/UPGRADE.md
index af7be3bcf5a..4a69145c655 100644
--- a/UPGRADE.md
+++ b/UPGRADE.md
@@ -8,6 +8,13 @@ awareness about deprecated code.
 
 # Upgrade to 4.0
 
+## Deprecated support for MariaDB 10.4 and MySQL 5.7
+
+* Upgrade to MariaDB 10.5 or later.
+* Upgrade to MySQL 8.0 or later.
+
+# Upgrade to 4.0
+
 ## BC BREAK: removed `AbstractMySQLPlatform` methods.
 
 1. `getColumnTypeSQLSnippets()`,
diff --git a/psalm.xml.dist b/psalm.xml.dist
index 9fabad3812d..609540b7d63 100644
--- a/psalm.xml.dist
+++ b/psalm.xml.dist
@@ -42,6 +42,17 @@
                 <file name="src/Driver/OCI8/ConvertPositionalToNamedPlaceholders.php"/>
             </errorLevel>
         </ConflictingReferenceConstraint>
+        <DeprecatedClass>
+            <errorLevel type="suppress">
+                <!--
+                    See https://github.com/doctrine/dbal/pull/6343
+                    TODO: remove in 5.0.0
+                -->
+                <referencedClass name="Doctrine\DBAL\Platforms\Keywords\MySQL80Keywords" />
+                <referencedClass name="Doctrine\DBAL\Platforms\MariaDB1052Platform" />
+                <referencedClass name="Doctrine\DBAL\Platforms\MySQL80Platform" />
+            </errorLevel>
+        </DeprecatedClass>
         <DeprecatedMethod>
             <errorLevel type="suppress">
                 <!--
diff --git a/src/Driver/AbstractMySQLDriver.php b/src/Driver/AbstractMySQLDriver.php
index 40d65076393..52ed2508526 100644
--- a/src/Driver/AbstractMySQLDriver.php
+++ b/src/Driver/AbstractMySQLDriver.php
@@ -15,6 +15,7 @@
 use Doctrine\DBAL\Platforms\MySQL80Platform;
 use Doctrine\DBAL\Platforms\MySQLPlatform;
 use Doctrine\DBAL\ServerVersionProvider;
+use Doctrine\Deprecations\Deprecation;
 
 use function preg_match;
 use function stripos;
@@ -43,6 +44,12 @@ public function getDatabasePlatform(ServerVersionProvider $versionProvider): Abs
                 return new MariaDB1052Platform();
             }
 
+            Deprecation::trigger(
+                'doctrine/dbal',
+                'https://github.com/doctrine/dbal/pull/6343',
+                'Support for MariaDB < 10.5.2 is deprecated and will be removed in DBAL 5',
+            );
+
             return new MariaDBPlatform();
         }
 
@@ -50,6 +57,12 @@ public function getDatabasePlatform(ServerVersionProvider $versionProvider): Abs
             return new MySQL80Platform();
         }
 
+        Deprecation::trigger(
+            'doctrine/dbal',
+            'https://github.com/doctrine/dbal/pull/6343',
+            'Support for MySQL < 8 is deprecated and will be removed in DBAL 5',
+        );
+
         return new MySQLPlatform();
     }
 
diff --git a/src/Platforms/Keywords/MySQL80Keywords.php b/src/Platforms/Keywords/MySQL80Keywords.php
index 331192ab2d4..bb0a29530ec 100644
--- a/src/Platforms/Keywords/MySQL80Keywords.php
+++ b/src/Platforms/Keywords/MySQL80Keywords.php
@@ -8,6 +8,8 @@
 
 /**
  * MySQL 8.0 reserved keywords list.
+ *
+ * @deprecated This class will be removed once support for MySQL 5.7 is dropped.
  */
 class MySQL80Keywords extends MySQLKeywords
 {
diff --git a/src/Platforms/MariaDB1052Platform.php b/src/Platforms/MariaDB1052Platform.php
index 2489637566d..2a26ab0bc7c 100644
--- a/src/Platforms/MariaDB1052Platform.php
+++ b/src/Platforms/MariaDB1052Platform.php
@@ -10,7 +10,7 @@
 /**
  * Provides the behavior, features and SQL dialect of the MariaDB 10.5 (10.5.2 GA) database platform.
  *
- * Note: Should not be used with versions prior to 10.5.2.
+ * @deprecated This class will be removed once support for MariaDB 10.4 is dropped.
  */
 class MariaDB1052Platform extends MariaDBPlatform
 {
diff --git a/src/Platforms/MySQL80Platform.php b/src/Platforms/MySQL80Platform.php
index 729fd6ddc0b..8d4baa08cb8 100644
--- a/src/Platforms/MySQL80Platform.php
+++ b/src/Platforms/MySQL80Platform.php
@@ -10,6 +10,8 @@
 
 /**
  * Provides the behavior, features and SQL dialect of the MySQL 8.0 (8.0 GA) database platform.
+ *
+ * @deprecated This class will be removed once support for MySQL 5.7 is dropped.
  */
 class MySQL80Platform extends MySQLPlatform
 {