-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename protected and private class members starting with an underscore #3004
Comments
For the rest of protected underscored members, imho the best approach would be to make them private and expose protected constructor instead(#3007 (comment)). Should this be too annoying, there could be a __get() polyfill of some sort. |
@Majkl578 you're still talking about breaking changes, right? Some of the currently protected variables like |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
According to PSR-2, protected and private property and method names should not be prefixed with an underscore. Currently, we have some of them in the code base:
In order to fix the coding standard violations, they should be renamed which would be backward incompatible. A major release could be used to make such a change.
The text was updated successfully, but these errors were encountered: