Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception hiearchy #3166

Open
Majkl578 opened this issue May 26, 2018 · 1 comment
Open

Improve exception hiearchy #3166

Majkl578 opened this issue May 26, 2018 · 1 comment
Labels
BC Break Error Handling Improvement

Comments

@Majkl578
Copy link
Contributor

Majkl578 commented May 26, 2018 •
edited by morozov
Loading

  1. All transaction-related exceptions extend ConnectionException which probably could renamed to TransactionException.
  2. NonUniqueFieldNameException directly extending ServerException is weird.
  3. TableExistsException extending ServerException is weird too.
  4. ServerException extending DriverException
  5. More like these.

This should be follow-up of #3525 once merged.
@Majkl578 Majkl578 added this to the 3.0.0 milestone May 26, 2018
@morozov
Copy link
Member

morozov commented Jun 2, 2019

Some remaining notes from the previous issue: #3131 (comment).

@morozov morozov mentioned this issue Jul 18, 2021
Merged
@morozov morozov removed this from the 4.0.0 milestone Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Error Handling Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morozov @Majkl578