Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove user provided PDO functionality #3545

Closed
jwage opened this issue May 10, 2019 · 3 comments
Closed

Remove user provided PDO functionality #3545

jwage opened this issue May 10, 2019 · 3 comments
Assignees
@morozov
Labels
BC Break Connections Improvement PDO
Milestone
3.0.0

Comments

@jwage
Copy link
Member

jwage commented May 10, 2019

See discussion about the functionality here #3487

If we remove it, we should maybe add some documentation showing a user how to build something to use an existing PDO connection or offer something outside of doctrine/dbal to solve the use case
@jwage jwage added the BC Break label May 10, 2019
@jwage jwage added this to the 3.0.0 milestone May 10, 2019
@SenseException
Copy link
Member

Related issue: #3544.

@morozov
Copy link
Member

morozov commented May 20, 2019

Keynotes for the documentation:

  1. Persistent connections are already supported, no need for a user-provided connection.
  2. In order to share the same PDO instances between DBAL and other components, initialize the connection in DBAL and access it using Connection::getWrappedConnection()->getWrappedConnection().

@morozov morozov mentioned this issue May 21, 2019
Merged
@morozov morozov closed this as completed May 22, 2019
@morozov morozov mentioned this issue May 22, 2019
Merged
@morozov morozov self-assigned this May 23, 2019
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Nov 17, 2020
@mdumoulin mdumoulin mentioned this issue Jul 27, 2021
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morozov morozov

Labels
BC Break Connections Improvement PDO
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@morozov @jwage @SenseException