Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent support for the $database parameter in AbstractSchemaManager::list*() methods #5284

Closed
morozov opened this issue Feb 18, 2022 · 1 comment · Fixed by #5289
Closed

Comments

@morozov
Copy link
Member

morozov commented Feb 18, 2022

The Schema Manager schema introspection methods don't support the $database parameter consistently. For instance:

  1. public function listSequences($database = null)
  2. public function listSchemaNames(): array
  3. public function listTableColumns($table, $database = null)
  4. public function listTableIndexes($table)

The lack of consistent support means that this API is not usable. Besides that, there isn't a single test that would cover the usage of the above methods that support the $database parameter with a database different than the current one.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant