Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractSchemaManager::introspectTable Triggers Deprecation Warning #6085

Closed
Aweptimum opened this issue Jul 5, 2023 · 1 comment
Closed

AbstractSchemaManager::introspectTable Triggers Deprecation Warning #6085

Aweptimum opened this issue Jul 5, 2023 · 1 comment

Comments

@Aweptimum
Copy link
Contributor

Bug Report

Q A
Version 3.5.x

Summary

Calling AbstractSchemaManager->introspectTable() (or the corresponding method in its subtypes) will trigger a deprecation as it calls listTableDetails() internally (which was deprecated in #5595).

Expected behaviour

introspectTable() isn't deprecated, so it shouldn't trigger a warning. The solution (as suggested by @greg0ire in the symfony slack) should be to use Deprecation::triggerIfCalledFromOutside within all instances of listTableDetails() rather than Deprecation::trigger

I will try to submit a PR. Just wanted to document it in case another maintainer has other thoughts.
@Aweptimum Aweptimum mentioned this issue Jul 5, 2023
Merged
@derrabus derrabus closed this as completed Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derrabus @Aweptimum