New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to Schema namespace #3565

Merged

jwage merged 1 commit into doctrine:develop from jwage:schema-types

May 29, 2019

Member

jwage commented May 28, 2019 •

edited

Loading

Q	A
Type	improvement
BC Break	yes

Summary

Improving types in Doctrine\DBAL\Schema.

jwage force-pushed the schema-types branch 2 times, most recently from 8449ce3 to dc2a3ec Compare

May 28, 2019 23:37

morozov reviewed

View reviewed changes

Member

morozov left a comment

Besides the need to introduce array_values(), looks solid. I'll see if I can run some more consistency checks on the changes later.

lib/Doctrine/DBAL/Event/SchemaColumnDefinitionEventArgs.php Outdated Show resolved Hide resolved

lib/Doctrine/DBAL/Platforms/SqlitePlatform.php Outdated Show resolved Hide resolved

lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php Show resolved Hide resolved

lib/Doctrine/DBAL/Schema/SQLServerSchemaManager.php Outdated Show resolved Hide resolved

tests/Doctrine/Tests/DBAL/Schema/ComparatorTest.php Outdated Show resolved Hide resolved

lib/Doctrine/DBAL/Schema/Visitor/Graphviz.php Outdated Show resolved Hide resolved

lib/Doctrine/DBAL/Schema/TableDiff.php Outdated Show resolved Hide resolved

lib/Doctrine/DBAL/Schema/Sequence.php Outdated Show resolved Hide resolved

lib/Doctrine/DBAL/Schema/Sequence.php Outdated Show resolved Hide resolved

morozov reviewed

View reviewed changes

lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php Outdated Show resolved Hide resolved

tests/Doctrine/Tests/DBAL/Functional/Driver/AbstractDriverTest.php Outdated Show resolved Hide resolved

jwage force-pushed the schema-types branch from 35adcbe to 34e5853 Compare

May 29, 2019 02:16

morozov reviewed

View reviewed changes

UPGRADE.md Outdated Show resolved Hide resolved

morozov reviewed

View reviewed changes

lib/Doctrine/DBAL/Schema/OracleSchemaManager.php Outdated Show resolved Hide resolved

morozov reviewed

View reviewed changes

lib/Doctrine/DBAL/Schema/Schema.php Show resolved Hide resolved

morozov reviewed

View reviewed changes

lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php Show resolved Hide resolved

morozov reviewed

View reviewed changes

lib/Doctrine/DBAL/Schema/Visitor/CreateSchemaSqlCollector.php Outdated Show resolved Hide resolved

morozov reviewed

View reviewed changes

lib/Doctrine/DBAL/Schema/Table.php Outdated Show resolved Hide resolved

jwage commented

View reviewed changes

lib/Doctrine/DBAL/Schema/SqliteSchemaManager.php Show resolved Hide resolved

morozov reviewed

View reviewed changes

Member

morozov left a comment

The recent changes look fine. We're almost there.

lib/Doctrine/DBAL/Schema/SchemaDiff.php Outdated Show resolved Hide resolved

UPGRADE.md Show resolved Hide resolved

jwage force-pushed the schema-types branch from 4537719 to 372d49b Compare

May 29, 2019 21:48


          Add proper types to Doctrine\DBAL\Schema namespace.

695f2fc

jwage force-pushed the schema-types branch from 372d49b to 695f2fc Compare

May 29, 2019 22:27

morozov approved these changes

View reviewed changes

Member

morozov left a comment •

edited

Loading

Awesome 👍 Size-wise, this is about 25% of the remaining type-related changes. In one shot!

Member Author

jwage commented May 29, 2019

Platforms has a bullseye on it now!

jwage merged commit 824f751 into doctrine:develop

jwage deleted the schema-types branch

May 29, 2019 23:30

jwage self-assigned this

jwage added the Improvement label

jwage added this to the 3.0.0 milestone

jwage added BC Break Schema Strict Typing labels

jwage mentioned this pull request

Bring over additional type changes to Doctrine\DBAL\Schema namespace. #3578

Closed

morozov pushed a commit to morozov/dbal that referenced this pull request


          Merge pull request doctrine#3565 from jwage/schema-types

1b06927

Add types to Schema namespace

morozov pushed a commit to morozov/dbal that referenced this pull request


          Merge pull request doctrine#3565 from jwage/schema-types

e8d535f

Add types to Schema namespace

morozov pushed a commit to morozov/dbal that referenced this pull request


          Merge pull request doctrine#3565 from jwage/schema-types

4fba0dc

Add types to Schema namespace

morozov pushed a commit to morozov/dbal that referenced this pull request


          Merge pull request doctrine#3565 from jwage/schema-types

6cee144

Add types to Schema namespace

morozov pushed a commit that referenced this pull request


          Merge pull request #3565 from jwage/schema-types

17649f8

Add types to Schema namespace

morozov pushed a commit that referenced this pull request


          Merge pull request #3565 from jwage/schema-types

a95f997

Add types to Schema namespace

morozov pushed a commit that referenced this pull request


          Merge pull request #3565 from jwage/schema-types

d88fac1

Add types to Schema namespace

morozov pushed a commit that referenced this pull request


          Merge pull request #3565 from jwage/schema-types

6a3267a

Add types to Schema namespace

morozov pushed a commit to morozov/dbal that referenced this pull request


          Merge pull request doctrine#3565 from jwage/schema-types

5d29e19

Add types to Schema namespace

morozov pushed a commit to morozov/dbal that referenced this pull request


          Merge pull request doctrine#3565 from jwage/schema-types

0a48456

Add types to Schema namespace

morozov pushed a commit to morozov/dbal that referenced this pull request


          Merge pull request doctrine#3565 from jwage/schema-types

f306738

Add types to Schema namespace

morozov pushed a commit that referenced this pull request


          Merge pull request #3565 from jwage/schema-types

4b3f0ee

Add types to Schema namespace

morozov added a commit to morozov/dbal that referenced this pull request


          Removed deprecation leftovers

e24b40a

1. `SqliteSchemaManager#_getPortableTableColumnList()` was mistakenly marked `@deprecated` instead of `#_getPortableTableIndexDefinition()` in doctrine#3565.
2. `OracleSchemaManager#_getPortableDatabaseDefinition()` was mistakenly marked `@deprecated` instead of `#_getPortableFunctionDefinition()` in doctrine#3565.
3. The deprecation message in the `OracleSchemaManager#createDatabase()` description is irrelevant as of doctrine#3565.

morozov mentioned this pull request

Removed deprecation leftovers #3804

Merged

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

BC Break Improvement Schema Strict Typing