From 12b528d03b80d97a07cf82e3edb3e9a6bcc1771c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Mon, 19 Oct 2020 21:28:43 +0200 Subject: [PATCH 1/3] Use sqlsrv 5.9.0-preview1 It has support for PHP8. --- .github/workflows/continuous-integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index f7d5b250368..eac4a131b71 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -445,7 +445,7 @@ jobs: coverage: "pcov" ini-values: "zend.assertions=1" tools: "pecl" - extensions: "${{ matrix.extension }}-5.7.0preview" + extensions: "${{ matrix.extension }}-5.9.0preview1" - name: "Cache dependencies installed with composer" uses: "actions/cache@v2" From f3cd606ad55d864bfe235a01f88e63b35bf1e08f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Mon, 19 Oct 2020 22:51:46 +0200 Subject: [PATCH 2/3] Skip test on PHP8 That test will get remove in next major release, and requires too much maintenance. --- tests/Doctrine/Tests/DBAL/Driver/OCI8/OCI8StatementTest.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Doctrine/Tests/DBAL/Driver/OCI8/OCI8StatementTest.php b/tests/Doctrine/Tests/DBAL/Driver/OCI8/OCI8StatementTest.php index e79869cf821..15e4d14eaeb 100644 --- a/tests/Doctrine/Tests/DBAL/Driver/OCI8/OCI8StatementTest.php +++ b/tests/Doctrine/Tests/DBAL/Driver/OCI8/OCI8StatementTest.php @@ -25,6 +25,7 @@ class OCI8StatementTest extends DbalTestCase * @param mixed[] $params * * @dataProvider executeDataProvider + * @requires PHP < 8.0 */ public function testExecute(array $params): void { From 94c02ccf6c4ff1690af1f710aa9529d81c3b2915 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Mon, 19 Oct 2020 21:12:32 +0200 Subject: [PATCH 3/3] Test all extensions with PHP8 Jobs that use other versions of PHP are temporarily removed so that it's easier to focus and iterate. --- .github/workflows/continuous-integration.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index eac4a131b71..698435312a2 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -76,6 +76,7 @@ jobs: matrix: php-version: - "7.4" + - "8.0" services: oracle: @@ -125,6 +126,7 @@ jobs: matrix: php-version: - "7.4" + - "8.0" services: oracle: @@ -315,7 +317,6 @@ jobs: matrix: php-version: - "7.4" - - "8.0" mysql-version: - "5.7" - "8.0" @@ -344,6 +345,16 @@ jobs: php-version: "7.4" mysql-version: "8.0" extension: "mysqli" + - php-version: "8.0" + mysql-version: "8.0" + extension: "mysqli" + custom-entrypoint: >- + --entrypoint sh mysql:8 -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password" + - php-version: "8.0" + mysql-version: "8.0" + extension: "pdo_mysql" + custom-entrypoint: >- + --entrypoint sh mysql:8 -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password" services: mysql: @@ -405,6 +416,7 @@ jobs: php-version: - "7.3" - "7.4" + - "8.0" extension: - "sqlsrv" - "pdo_sqlsrv"