MySQL 8.4 Platform

[wmouwen]

Q	A
Type	improvement
Fixed issues	none

Summary

MySQL 8.4 introduces a new set of reserved keywords (link). This PR adds a new platform definition for MySQL 8.4 and higher.

Related

• Run tests against MySQL 8.4 #6386

[derrabus]

Can you please rebase your PR, so #6386 is taken into account and we test your PR against MySQL 8.4?

[wmouwen]

The current test that fails is due to a reported MySQL bug: https://bugs.mysql.com/bug.php?id=114876

Details

There was 1 failure:

1) Doctrine\DBAL\Tests\Functional\ExceptionTest::testInvalidUserName
Failed asserting that exception of type "Doctrine\DBAL\Exception\DriverException" matches expected exception "Doctrine\DBAL\Exception\ConnectionException". Message was: "An exception occurred in the driver: Plugin 'mysql_native_password' is not loaded" at
/home/runner/work/dbal/dbal/src/Driver/Mysqli/Exception/ConnectionFailed.php:34
/home/runner/work/dbal/dbal/src/Driver/Mysqli/Driver.php:54
/home/runner/work/dbal/dbal/src/Connection.php:378
/home/runner/work/dbal/dbal/tests/Functional/ExceptionTest.php:340
/home/runner/work/dbal/dbal/tests/Functional/ExceptionTest.php:303
.

FAILURES!
Tests: 4480, Assertions: 6696, Failures: 1, Skipped: 722, Incomplete: 5.

[greg0ire]

That was addressed in #6388, wasn't it?

[wmouwen]

That was addressed in #6388, wasn't it?

Yep, sure is. Seems like IBM fixed their download issues as well. Could someone re-run the checks?

[greg0ire]

The code looks OK to me. @derrabus do we have a statement somewhere explaining why it's OK to target 3.9.x here?

[derrabus]

do we have a statement somewhere explaining why it's OK to target 3.9.x here?

Support for newer database platforms is probably okay-ish…? 🫣

[greg0ire]

I think so as well, although it cannot quite formulate why we have that exception.

[wmouwen]

The docs make it look like MySQL 8.4 is explicitly supported by DBAL 3.*, however these new keywords not getting quoted can be seen as a bug. So instead of new platform support, you could call it a bugfix?

[greg0ire]

Indeed. Plus, Doctrine does not crash with PlatformNotSupportedYet or similar upon using 8.4 right now, so it could definitely be seen as a fix.

[derrabus]

MySQL 8.4 also removed a couple of keywords, see https://dev.mysql.com/doc/refman/8.4/en/keywords.html#keywords-removed-in-current-series. How shall we proceed with those?

[wmouwen]

MySQL 8.4 also removed a couple of keywords, see https://dev.mysql.com/doc/refman/8.4/en/keywords.html#keywords-removed-in-current-series. How shall we proceed with those?

Those can be removed using array_diff() in the MySQL84Keywords::getKeywords() method. Could do so in this PR, could do so in a new PR as well.

[derrabus]

Let's do that in a follow-up. Thanks!