-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean elses #1691
Clean elses #1691
Conversation
As this overlaps with what's happening right now in |
Didn't know that was a branch for next version development already 😅 |
There's that big #1553 that switches us to the new driver and moves all relevant things (including query/aggregation builders) from |
I've tagged this for the 2.0 milestone and will take a look once #1553 has been merged down. I'll try to get that done within a week or so, after that improvement PRs such as this can be based on odm-ng (or master if I can finally push myself to just merge odm-ng down). |
@carusogabriel could you rebase this pull request? |
Sure, I’ll rebase and search for similars 👨💻 |
@alcaeus Only one test failed because of |
Done. |
Thanks @carusogabriel! |
I've removed the
else
s when we have already returned something 🚮