[2.0] Disallow nested commits #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Jan 9, 2018
|
|
||
| public static function commitInProgress() | ||
| { | ||
| return new self('There is already a commit operation in progress'); |
There was a problem hiding this comment.
Maybe add an explanation, like did you call flush from an event listener?
There was a problem hiding this comment.
Asking about event listener is indeed better than just saying that flush from there is forbidden, adding it 👍
malarzm
force-pushed
the
nested-commit-exception
branch
from
5597221
to
324d84b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.