Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish renaming dirtyCheck methods #1942

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Jan 22, 2019

Finishes work started in #1938. ORM may not have renamed that method yet, but it makes sense to keep method names similar instead of having multiple names for the same functionality.

Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an entry to the UPGRADE file?

@alcaeus
Copy link
Member Author

alcaeus commented Jan 22, 2019

Ah, yes. Will do 👍

@alcaeus alcaeus merged commit 24b12a0 into doctrine:master Jan 23, 2019
@alcaeus alcaeus deleted the finish-renaming-dirty-check branch January 23, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants