Mark methods and classes as internal #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not include adding |
malarzm
commented
Feb 19, 2019
| @@ -71,14 +71,12 @@ public function isDirty(); | |||
| public function setDirty($dirty); | |||
|
|
|||
| /** | |||
| * INTERNAL: | |||
There was a problem hiding this comment.
Entire interface is marked as internal
malarzm
commented
Feb 19, 2019
alcaeus
reviewed
Feb 20, 2019
malarzm
force-pushed
the
mark-stuff-as-internal
branch
from
10f6ca9
to
3ca5163
Compare
alcaeus
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1931 for details. I've added a note that we can also remove internal stuff in minor releases as I saw a number of methods that should not be added in the first place and I thought that we could remove them in 2.1 (such as
HydratorFactory::setUnitOfWorkwhich should be passed in ctor).