Remove copy() method from EntityManager #6794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, this PR should target develop as it's the development branch for 3.0.
IMO, no.
Yes. Deprecation needs to happen in master. |
|
@alcaeus Should I close this PR and recreate it with a branch from develop for the copy-removal? |
|
You can rebase this branch on top of develop and change the base of the pull request: |
|
@guilhermeblanco was rebasing develop to sync with the latest changes in master, so I'd recommend to ensure that he's done with it before of merging this PR |
|
The deprecation PR to master will follow. |
|
The deprecation PR is done in #6803. |
alcaeus
approved these changes
Nov 9, 2017
guilhermeblanco
force-pushed
the
develop
branch
from
9f5fd37
to
e7d61c2
Compare
|
This will need a rebase now. |
Majkl578
approved these changes
Dec 8, 2017
|
@SenseException Thanks. Let's handle deprecation for 2.x in #6803 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
EntityManager::copy()is a pretty old addition to Doctrine and never got any functionality, which is why I created this PR to remove this method from theEntityManager.Because I had to remove this method from
EntityManagerInterfacetoo, I consider this a BC break. Even though the originalEntityManagernever got any functionality for copy, a user may have created a custom entity manager for a project, that uses a custom implementation of copy.Questions: