Deprecation of EntityManager copy method #6803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Nov 9, 2017
|
Deprecation of |
alcaeus
approved these changes
Nov 9, 2017
|
@SenseException thanks, let's hold this a bit though. The idea is to start adding deprecation notes in |
|
Since we're about to start using |
Majkl578
reviewed
Dec 8, 2017
UPGRADE.md
Outdated
| @@ -21,6 +21,11 @@ Method `Doctrine\ORM\Query\Parser#overwriteInternalDQLFunctionNotAllowed` was | |||
| removed because of the choice to allow users to overwrite internal functions, ie | |||
| `AVG`, `SUM`, `COUNT`, `MIN` and `MAX`. [#6500](https://github.com/doctrine/doctrine2/pull/6500) | |||
|
|
|||
| ## Deprecated: `Doctrine\ORM\EntityManagerInterface#copy()` | |||
|
|
|||
| Method `Doctrine\ORM\EntityManagerInterface#copy` never got its implementation and is deprecated. | |||
There was a problem hiding this comment.
Please add () after method name.
|
I can't imagine how this could be a real BC break since the only implementation ever was an exception. 🤣 But well, it's in the interface anyway... |
|
@SenseException a rebase is still needed, sorry |
|
@Ocramius After the base branch is 2.7 now, I should rebase against that one instead master, right? |
|
Yes, master is 3.0 now. |
|
Done. |
Ocramius
suggested changes
Jan 4, 2018
UPGRADE.md
Outdated
| @@ -30,6 +30,11 @@ As a consequence, automatic cache setup in Doctrine\ORM\Tools\Setup::create*Conf | |||
| - Memcached extension (ext-memcached) will be used instead of obsolete Memcache (ext-memcache). | |||
| - XCache support was dropped as it doesn't work with PHP 7. | |||
|
|
|||
| ## Deprecated: `Doctrine\ORM\EntityManagerInterface#copy()` | |||
There was a problem hiding this comment.
This section should be above # Upgrade to 2.6 and have a title # Upgrade to 2.7
There was a problem hiding this comment.
The new version headline is created and the deprecation text is assigned to it.
Ocramius
approved these changes
Jan 4, 2018
|
@SenseException thanks! 🚢 |
vilartoni
added a commit
to Emagister/doctrine-orm
that referenced
this pull request
Jan 14, 2020
…gin-master v2.7.0 [](https://travis-ci.org/doctrine/orm) This release solves Symfony 5.0 compatibility issues, some small improvements, and adds various deprecation notices. Please read carefully the [upgrade to 2.7 notes](https://github.com/doctrine/orm/blob/2.7/UPGRADE.md#upgrade-to-27) to know more about the reasons and how to fix the deprecation messages. --- - Total issues resolved: **1** - Total pull requests resolved: **15** - Total contributors: **10** Deprecation ----------- - [7911: Be explicit about which Doctrine package in message](doctrine#7911) thanks to @lcobucci - [7909: Add deprecation messages](doctrine#7909) thanks to @lcobucci - [7901: Add deprecation warnings for 2.7.x](doctrine#7901) thanks to @lcobucci - [7701: Split and deprecate AbstractQuery#useResultCache()](doctrine#7701) thanks to @someniatko CI -- - [7904: Make sure composer files are valid](doctrine#7904) thanks to @greg0ire - [7600: &doctrine#91;2.7&doctrine#93; CI: Test against PHP 7.4snapshot instead of nightly (8.0)](doctrine#7600) thanks to @Majkl578 Improvement ----------- - [7876: Fix compat of commands with Symfony 5](doctrine#7876) thanks to @nicolas-grekas - [7829: Skip Paginator LIMIT subquery and WHERE IN if query do not have LIMIT](doctrine#7829) thanks to @Seb33300 - [7723: Allow Symfony 5.0](doctrine#7723) thanks to @nicolas-grekas - [7710: Prettified arrays in tool command orm:mapping:describe](doctrine#7710) thanks to @rtek - [7340: Fix config template for PHPUnit >= 7.2](doctrine#7340) thanks to @guilliamxavier BC Break,Improvement -------------------- - [7863: Paginator: Skip limit subquery if not required](doctrine#7863) thanks to @Seb33300 Documentation ------------- - [7382: Update homepage](doctrine#7382) thanks to @Majkl578 Bug --- - [7326: Cherry-pick doctrine#7307 to fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common](doctrine#7326) thanks to @nicolas-grekas - [7079: Fix getJoinTableName for sqlite with schema attribute](doctrine#7079) thanks to @mairo744 BC Break,Deprecation,Improvement -------------------------------- - [6803: Deprecation of EntityManager copy method](doctrine#6803) thanks to @SenseException
](https://travis-ci.org/doctrine/orm){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow @alcaeus' procedure mentioned in #6794, I create this PR to deprecate the method
EntityManagerInterface::copy()on the master branch.