Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Infer @private for #-prefixed private methods #1590

Open
LeaVerou opened this issue Jan 21, 2023 · 1 comment
Open

Feature request: Infer @private for #-prefixed private methods #1590

LeaVerou opened this issue Jan 21, 2023 · 1 comment

Comments

@LeaVerou
Copy link

I was surprised I had to add @private for #-prefixed functions to be recognized as private, it seems relatively straightforward to infer.

Possibly related: #1355

@tannerstern
Copy link

I was going to suggest using the --infer-private option with --infer-private "^#" but for whatever reason that doesn't work. In the output it appears the # character is stripped from function names some time before the "infer access" step. I tried again with --infer-private "^_" as exampled in the source code which did work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants