Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify message when no submitted solution was selected #4315

Closed
Tracked by #4364
pdawyndt opened this issue Jan 14, 2023 · 1 comment · Fixed by #5056
Closed
Tracked by #4364

Clarify message when no submitted solution was selected #4315

pdawyndt opened this issue Jan 14, 2023 · 1 comment · Fixed by #5056
Labels
bug Something isn't working low priority Thing we want to see implemented at some point

Comments

@pdawyndt
Copy link
Contributor

In an evaluation, this is the message you get to see if a student did not submit any solutions before the deadline, but did submit solutions after the deadline (e.g. when student was admitted to work longer than the other students).

The user has 2 attempts for this exercise. [Select another submission.](https://dodona.ugent.be/en/feedbacks/2128419246/edit/)

The word "another" is confusing here, as it suggets that a solution has already been selected (which is not the case). So it should better be replaced to avoid this confusion. Even better, we might also add explicitly that no solution has been selected yet (the empty space where otherwise the solution would be displayed looks a good place to bring this into the attention of reviewers).

image

@pdawyndt pdawyndt added the bug Something isn't working label Jan 14, 2023
@bmesuere bmesuere added this to Roadmap Jan 14, 2023
@github-project-automation github-project-automation bot moved this to Unplanned in Roadmap Jan 14, 2023
@pdawyndt
Copy link
Contributor Author

pdawyndt commented Jan 14, 2023

After selecting a solution for this student, the submission remains "completed" with a zero score. This is a dangerous situation, because it means that this submission will probably be skipped if the "completed" status and the zero scores are not adjusted at this point. So we should give more attention to this at this point.

(I somewhat recall that this issue was already raised, but I couldn't find it among the open issues)

EDIT: Upon second inspection it seems that the "completed" status is indeed removed (but strong visual clue about this on the page; only icon next to the total score it an indicator of this), but the zero scores remain in place. So, still something that could be improved in my opinion.

image

@chvp chvp added the low priority Thing we want to see implemented at some point label Jan 19, 2023
@chvp chvp moved this from Unplanned to Todo in Roadmap Jan 19, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Thing we want to see implemented at some point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants