Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend allowed attributes (svg) #5250

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Extend allowed attributes (svg) #5250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def sanitize(html)
%w[svg g style circle line rect path polygon text]
@attributes ||= Rails::Html::SafeListSanitizer.allowed_attributes.to_a +
%w[style target data-bs-toggle data-parent data-tab data-line data-element id] +
%w[viewBox width height version style class transform id x y rx ry x1 y1 x2 y2 d points fill stroke stroke-width cx cy r font-size font-family font-weight font-variant]
%w[viewBox width height version style class transform id x y rx ry x1 y1 x2 y2 d points fill stroke stroke-width stroke-dasharray cx cy r font-size font-family font-weight font-variant textLength writing-mode glyph-orientation-vertical text-orientation]

# Filters allowed tags and attributes
sanitized = ActionController::Base.helpers.sanitize html,
Expand Down
5 changes: 4 additions & 1 deletion test/helpers/application_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ class ApplicationHelperTest < ActiveSupport::TestCase
dirty_html = <<~HTML
<svg viewBox="0 0 100 100" width="300" height="100" version="1.1">
<style>line,circle{stroke-width:3px;stroke:black;stroke-linecap:round}</style>
<style>test{stroke-width:3px;stroke:black;stroke-linecap:round}</style>
<style>test{stroke-width:3px;stroke:black;stroke-dasharray:1;stroke-linecap:round}</style>
<style>text.vertical{writing-mode:tb;glyph-orientation-vertical:0;fill:grey;}</style>
<style>text.vertical{writing-mode:vertical-rl;text-orientation:upright;}</style>
<g id="group1" transform="translate(50,50)">
<circle cx="0" cy="0" r="40" fill="none"></circle>
<line class="test" x1="0" y1="0" x2="0" y2="-40"></line>
Expand All @@ -113,6 +115,7 @@ class ApplicationHelperTest < ActiveSupport::TestCase
<polygon points="0,0 100,0 100,100 0,100"></polygon>
<path d="M0,0 L100,0 L100,100 L0,100 Z"></path>
<text x="0" y="0" font-size="14px" font-weight="bold" font-variant="normal" font-family="serif">Hello</text>
<text x="0" y="0" textLength="10">abcdefgh</text>
</svg>
HTML
clean_html = sanitize dirty_html
Expand Down