Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copy course button more prominent for featured courses #5360

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Feb 12, 2024

This pull request makes the copy course button more prominent for featured courses.

Featured courses are mainly used as templates for teachers. It thus makes sense to make copying such a course the primary highlighted action for teachers.

image

The copy course card replaces the subscribe card for teachers. The subscribe button is moved to same location as the unsubscribe location.

This allowed me to make use of this space in the card to add some extra information for new teachers and redirect them to our documentation.

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Feb 12, 2024
@jorg-vr jorg-vr self-assigned this Feb 12, 2024
@jorg-vr jorg-vr marked this pull request as ready for review February 12, 2024 16:51
@jorg-vr jorg-vr requested a review from a team as a code owner February 12, 2024 16:51
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team February 12, 2024 16:51
app/views/courses/show.html.erb Outdated Show resolved Hide resolved
app/views/courses/show.html.erb Outdated Show resolved Hide resolved
jorg-vr and others added 2 commits February 12, 2024 17:56
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com>
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com>
config/locales/views/courses/en.yml Outdated Show resolved Hide resolved
config/locales/views/courses/nl.yml Outdated Show resolved Hide resolved
jorg-vr and others added 2 commits February 13, 2024 09:36
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
@jorg-vr jorg-vr merged commit 6850c32 into main Feb 13, 2024
13 checks passed
@jorg-vr jorg-vr deleted the enhance/coppy-course branch February 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants