Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add txpool config into metrics server #32

Merged
merged 1 commit into from
Sep 12, 2023
Merged

metrics: add txpool config into metrics server #32

merged 1 commit into from
Sep 12, 2023

Conversation

0xcb9ff9
Copy link

Description

upstream PR bnb-chain#1788

add TxPool info into metrics server

Changes

  • cmd/utils/flags.go
  • cmd/geth/config.go

@0xcb9ff9 0xcb9ff9 added the upstream upstream PR label Sep 12, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Sep 12, 2023
DarianShawn
DarianShawn approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarianShawn DarianShawn added this pull request to the merge queue Sep 12, 2023
Merged via the queue into dev with commit 416e1b3 Sep 12, 2023
5 checks passed
@DarianShawn DarianShawn deleted the upstream/bsc-1788-txpool-metrics branch September 12, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
upstream upstream PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xcb9ff9 @DarianShawn @zlacfzy