Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled autoplay but it's start after first slide #111

Closed
c0nsoleg opened this issue Jan 21, 2022 · 6 comments
Closed

disabled autoplay but it's start after first slide #111

c0nsoleg opened this issue Jan 21, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@c0nsoleg
Copy link

c0nsoleg commented Jan 21, 2022

Hi,

Is it intended, even if I have autoPlay set to false, that carousel run through all slides after I manually change slide once?
My carousel code:

<Carousel
  width={width}
  height={200}
  loop={false}
  mode="parallax"
  autoPlay={false}
  modeConfig={{
    parallaxScrollingScale: 0.96,
    parallaxScrollingOffset: 18,
  }}
  onProgressChange={(_: any, absoluteProgress: number) =>
    (progressValue.value = absoluteProgress)
  }
  data={JSON.parse(JSON.stringify(profileAbilities))}
  renderItem={({item}: {item: ProfilePlayerAbility}) => (
    <Block key={item.category}>
      <ProfileAbilityCategory {...{item}} />
    </Block>
  )}
/>
@dohooo
Copy link
Owner

dohooo commented Jan 21, 2022

Ok let me have a look

@jihoon416
Copy link

Same here. It doesn't happen when I downgrade to 2.1.2

@jihoon416
Copy link

Just found out that the automatic sliding will stop when you touch the currently snapped item.

@dohooo
Copy link
Owner

dohooo commented Jan 22, 2022

Just found out that the automatic sliding will stop when you touch the currently snapped item.

Yes, that's our current default logic

@jihoon416
Copy link

Ahh sorry for stating the obvious 😅 Today's my first time using this library and so far I am really enjoying how simple it is to animate. Thank you for your work!

@dohooo
Copy link
Owner

dohooo commented Jan 22, 2022

Ahh sorry for stating the obvious 😅 Today's my first time using this library and so far I am really enjoying how simple it is to animate. Thank you for your work!

Thank you for using it 😄

Hi,

Is it intended, even if I have autoPlay set to false, that carousel run through all slides after I manually change slide once? My carousel code:

<Carousel
  width={width}
  height={200}
  loop={false}
  mode="parallax"
  autoPlay={false}
  modeConfig={{
    parallaxScrollingScale: 0.96,
    parallaxScrollingOffset: 18,
  }}
  onProgressChange={(_: any, absoluteProgress: number) =>
    (progressValue.value = absoluteProgress)
  }
  data={JSON.parse(JSON.stringify(profileAbilities))}
  renderItem={({item}: {item: ProfilePlayerAbility}) => (
    <Block key={item.category}>
      <ProfileAbilityCategory {...{item}} />
    </Block>
  )}
/>

it may be a bug, I will fix it tomorrow at the latest

@dohooo dohooo self-assigned this Jan 22, 2022
@dohooo dohooo added the bug Something isn't working label Jan 22, 2022
@dohooo dohooo closed this as completed in 6aa3cc4 Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants